From: Jeff King <peff@peff.net>
Date: Tue, 11 Nov 2008 00:31:36 GMT
Subject: Re: Git Notes - Track rebase/etc + reverse-lookup for bugs ideas
Message-ID: <20081111003136.GA26481@coredump.intra.peff.net>
In-Reply-To: <74EBEC20-FC39-444E-8B96-31E5B36894B8@gmail.com>

On Mon, Nov 10, 2008 at 03:26:52PM -0500, Thomas Harning wrote:

> What I intended is that if notes are attached to 'A',  A` (after a  
> rebase) will have the exact same note.

I think that may have been brought up at the GitTogether. It would be
very easy, when rebasing A to A', to copy any notes for A to A'
(retroactively applying notes for A' to A (or vice versa) is much
harder, since we don't maintain any mapping between the two).

_But_ that is not necessarily a good idea in all cases, because your
notes may say certain things about A like "I tested this on system X".
But you _haven't_ tested A', and it might not pass your test. Leaving
aside editing the commits with "rebase -i", there might just be a bad
interaction with the commit you rebased onto.

So I think it would probably make sense to add a "--copy-notes" option
to rebase for those times when the user knows it makes sense, but doing
so by default is probably a mistake.

-Peff