git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git commit -v does not removes the patch

From
Jeff King <peff@peff.net>
Date
Nov 11, 2008, 00:07 UTC
Message-ID
<20081111000706.GA26223@coredump.intra.peff.net>
In-Reply-To
<7vej1j40x5.fsf@gitster.siamese.dyndns.org>
On Mon, Nov 10, 2008 at 03:27:18PM -0800, Junio C Hamano wrote:
> > It is exactly as you described. I'll try in other systems.
> 
> Guess in the dark... by any chance are you enabling color unconditionally?
I thought I covered that case explicitly...

...yes, I can't reproduce with color set to "always". And indeed, looking at the diff for 4f672ad shows that we always turn off color for the message that goes to the editor (since we can't trust our isatty setting _anyway_, since we're not going to the tty).

So that's not it.
-Peff
Previous: Junio C HamanoNext: Santi Béjar
Message 5 of 22 in “git commit -v does not removes the patch”
  1. Santi BéjarNov 10, 2008
  2. Jeff KingNov 10, 2008
  3. Santi BéjarNov 10, 2008
  4. Junio C HamanoNov 10, 2008
  5. Jeff KingNov 11, 2008
  6. Santi BéjarNov 11, 2008
  7. Jeff KingNov 11, 2008
  8. Santi BéjarNov 11, 2008
  9. Junio C HamanoNov 11, 2008
  10. Jeff KingNov 12, 2008
  11. 1/5 define empty tree sha1 as a macroJeff King, Nov 12, 2008
  12. 2/5 wt-status: refactor initial commit printingJeff King, Nov 12, 2008
  13. 3/5 status: show "-v" diff even for initial commitJeff King, Nov 12, 2008
  14. 4/5 commit: loosen pattern for matching "-v" diffJeff King, Nov 12, 2008
  15. 5/5 commit: only strip diff from message in verbose modeJeff King, Nov 12, 2008
  16. Jeff KingNov 12, 2008
  17. Junio C HamanoNov 13, 2008
  18. SZEDER GáborNov 20, 2008
  19. Jeff KingNov 20, 2008
  20. SZEDER GáborNov 22, 2008
  21. Jeff KingNov 22, 2008
  22. Junio C HamanoNov 22, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.