From: Jeff King Date: Tue, 11 Nov 2008 00:07:06 GMT Subject: Re: git commit -v does not removes the patch Message-ID: <20081111000706.GA26223@coredump.intra.peff.net> In-Reply-To: <7vej1j40x5.fsf@gitster.siamese.dyndns.org> On Mon, Nov 10, 2008 at 03:27:18PM -0800, Junio C Hamano wrote: > > It is exactly as you described. I'll try in other systems. > > Guess in the dark... by any chance are you enabling color unconditionally? I thought I covered that case explicitly... ...yes, I can't reproduce with color set to "always". And indeed, looking at the diff for 4f672ad shows that we always turn off color for the message that goes to the editor (since we can't trust our isatty setting _anyway_, since we're not going to the tty). So that's not it. -Peff