Re: JGIT: discuss: diff/patch implementation
- From
- Francis Galiegue <fg@one2team.net>
- Date
- Nov 10, 2008, 18:11 UTC
- Message-ID
- <200811101911.19603.fg@one2team.net>
- In-Reply-To
- <200811101759.03864.robin.rosenberg@dewire.com>
Le Monday 10 November 2008 17:59:03 Robin Rosenberg, vous avez écrit : [Sorry if this is offtopic for the git mailing list...]
Show 10 quoted lines
> > > > Well, this API has a problem from the get go, since it does... Char by > > char comparison. Ouch. > > > > I'll try and hack it so that it does line by line, but given my Java > > skills, uh... > > We might want a byte-oriented version. Converting to char first is way > too slow. >
Well, AFAICT, here is how the current git code detects whether a file is binary or not:
----
#define FIRST_FEW_BYTES 8000
int buffer_is_binary(const char *ptr, unsigned long size)
{
if (FIRST_FEW_BYTES < size)
size = FIRST_FEW_BYTES;
return !!memchr(ptr, 0, size);
}
----Easy enough to be coded in Java, hey, even I could do it :p
So, provided binary files are dealt with already, what penalty is left for Java to deal with?
-- fge