Re: JGIT: discuss: diff/patch implementation

From: Robin Rosenberg <robin.rosenberg@dewire.com>
Date: Nov 10, 2008, 16:59 UTC
Message-ID: <200811101759.03864.robin.rosenberg@dewire.com>
In-Reply-To: <200811101716.29029.fg@one2team.net>

måndag 10 november 2008 17:16:28 skrev Francis Galiegue:

Show 26 quoted lines

> Le Monday 10 November 2008 16:56:35 Robin Rosenberg, vous avez écrit :
> [...]
> > >
> > > I found this:
> > >
> > > http://code.google.com/p/google-diff-match-patch
> > >
> > > Its license is the Apache 2.0 license. It implements the same algorithm
> > > than git's internal diff engine ("An O(ND) Difference Algorithm and its
> > > Variations", by Eugene Myers), and as far as I can tell so far (IANAL,
> > > far from it), it is compatible with JGit's current license.
> > >
> > > Could this be a viable candidate?
> >
> > Our approach was to do just that, for the very reasons you mention.
> > I'll have a look. Thanks for doing some research for us. That project was
> > unknown to me..
> >
> > -- robin
> 
> Well, this API has a problem from the get go, since it does... Char by char 
> comparison. Ouch.
> 
> I'll try and hack it so that it does line by line, but given my Java skills, 
> uh...
>

We might want a byte-oriented version. Converting to char first is way too slow.

-- robin