git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] add -p: warn if only binary changes present

From
Thomas Rast <trast@student.ethz.ch>
Date
Oct 26, 2008, 10:28 UTC
Message-ID
<200810261128.14735.trast@student.ethz.ch>
In-Reply-To
<20081026051013.GD21178@coredump.intra.peff.net>
Jeff King wrote:
Show 7 quoted lines
> > +			print STDERR "No changes except to binary files.\n";
> 
> This wording seems a little awkward to me, though. Maybe
> 
>   No changed text files.
> 
> ?

I tried to make a more precise statement. "No changed text files" also holds if no files at all were changed. A user can only infer that there _are_ binary changes if he knows that the message in the latter case would have been "No changes".

That being said, it is somewhat awkward, I just couldn't come up with a better message with this meaning. I considered some other options, such as giving a hint to use git-add or running git-status for the user, but these would have been far more verbose.

- Thomas
-- 
Thomas Rast
trast@{inf,student}.ethz.ch
Previous: Jeff KingNext: SZEDER Gábor
Message 3 of 6 in “add -p: warn if only binary changes present”
  1. add -p: warn if only binary changes presentThomas Rast, Oct 24, 2008
  2. Jeff KingOct 26, 2008
  3. Thomas RastOct 26, 2008
  4. SZEDER GáborOct 26, 2008
  5. add -p: warn if only binary changes presentThomas Rast, Oct 26, 2008
  6. Jeff KingOct 26, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.