Re: [PATCH] add -p: warn if only binary changes present

From: Jeff King <peff@peff.net>
Date: Oct 26, 2008, 05:10 UTC
Message-ID: <20081026051013.GD21178@coredump.intra.peff.net>
In-Reply-To: <1224884916-20369-1-git-send-email-trast@student.ethz.ch>

On Fri, Oct 24, 2008 at 11:48:36PM +0200, Thomas Rast wrote:

> Current 'git add -p' will say "No changes." if there are no changes to
> text files, which can be confusing if there _are_ changes to binary
> files.  Add some code to distinguish the two cases, and give a
> different message in the latter one.

Having just looked at this code (for potentially handling "git add -p" of new files), I think this change is sane.

> +			print STDERR "No changes except to binary files.\n";

This wording seems a little awkward to me, though. Maybe

  No changed text files.

-Peff