Re: Git and tagging hook

From: Jan Hudec <bulb@ucw.cz>
Date: Oct 14, 2008, 17:22 UTC
Message-ID: <20081014172227.GB6931@efreet.light.src>
In-Reply-To: <48ECF072.3000506@op5.se>

On Wed, Oct 08, 2008 at 19:40:02 +0200, Andreas Ericsson wrote:

Show 5 quoted lines

> Kristis Makris wrote:
>> On Tue, 2008-10-07 at 19:28 +0200, Jakub Narebski wrote:
>>> Kristis Makris wrote:
>>>> I want the integration when I apply the tag to a local repository, NOT
>>>> only when I push/pull.

Care to explain why that would ever be useful? It's local, which means that:
 - the user can take it back without a trace it ever happened (git tag -d or
   even git update-ref -d) and
 - noone except the user will see it anyway, so it's not like they should
   care either.

Besides, you don't need git tag to create a tag in git, so the hook wouldn't really be guaranteed anyway (I mean, just like the commit hook is not -- you can still commit by calling write-tree, commit-tree and update-ref and avoid the hook).

Show 20 quoted lines

>>> If you are talking about taging locally, you can simply make an alias
>>> or do something after tagging. Search archives for description when
>>> it is worth to add a hook, and when it is not.
>>
>> I am looking for a guarantee that is better than casually saying
>> "simply". I will be providing the integration work to users that may not
>> be as comfortable with making aliases. 
>>
>> I still don't see why a hook on local tagging is not available. Is it
>> possible to add support in Git for such a hook ? Both pre-tag and
>> post-tag.
>
> Because noone's ever needed one before. If aliases can't do what you
> want, write a patch to support it and hope Junio accepts it. It's really
> quite straight-forward. Make sure you read Documentation/SubmittingPatches
> before you send it.
>
> Note though that use of tags on the developer's side will still be up
> to the developer and not something you can force through other means
> than policy or convention.

Being possible was never a reason to add features to git and the less it was a reason to add hooks. And there does not seem to be a use-case that would clearly benefit from having such hooks, or at least none was shown on the list so far.

For integration with issue tracker, the local tag is neither final, nor useful to anybody except the user who did it until it hits the central repository. And working on the central repository directly does not seem like a good idea either.

-- 
						 Jan 'Bulb' Hudec <bulb@ucw.cz>