git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2] Fix testcase failure when extended attributes are in use

From
Deskin Miller <deskinm@umich.edu>
Date
Oct 14, 2008, 02:10 UTC
Message-ID
<20081014021016.GB14994@riemann.deskinm.fdns.net>
In-Reply-To
<20081011154107.GA14994@riemann.deskinm.fdns.net>

06cbe855 (Make core.sharedRepository more generic, 2008-04-16) made several testcases in t1301-shared-repo.sh which fail if on a system which creates files with extended attributes (e.g. SELinux), since ls appends a '+' sign to the permission set in such cases. This fixes the testcase to strip any such sign prior to verifying the permission set.

Signed-off-by: Deskin Miller <deskinm@umich.edu>
---
...and then I discovered Documentation/CodingGuidelines: no ? in regular
expressions.  I really need to learn these shell variable-manipulation
builtins.

Apologies if for some reason the previous version got used, I haven't seen it anywhere, however.

Deskin Miller
 t/t1301-shared-repo.sh |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/t/t1301-shared-repo.sh b/t/t1301-shared-repo.sh
index dc85e8b..4d2db62 100755
--- a/t/t1301-shared-repo.sh
+++ b/t/t1301-shared-repo.sh
@@ -84,6 +84,7 @@ do
 		git update-server-info &&
 		actual="$(ls -l .git/info/refs)" &&
 		actual=${actual%% *} &&
+		actual=${actual%+} &&
 		test "x$actual" = "x-$y" || {
 			ls -lt .git/info
 			false
@@ -97,6 +98,7 @@ do
 		git update-server-info &&
 		actual="$(ls -l .git/info/refs)" &&
 		actual=${actual%% *} &&
+		actual=${actual%+} &&
 		test "x$actual" = "x-$x" || {
 			ls -lt .git/info
 			false
-- 
1.6.0.2.514.g23abd3
Previous: Deskin MillerNext: Junio C Hamano
Message 2 of 7 in “Fix testcase failure when extended attributes are in use”
  1. Fix testcase failure when extended attributes are in useDeskin Miller, Oct 11, 2008
  2. Fix testcase failure when extended attributes are in useDeskin Miller, Oct 14, 2008
  3. Junio C HamanoOct 17, 2008
  4. Deskin MillerOct 19, 2008
  5. Junio C HamanoOct 19, 2008
  6. Deskin MillerOct 19, 2008
  7. Junio C HamanoOct 20, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.