From: Deskin Miller Date: Tue, 14 Oct 2008 02:10:16 GMT Subject: [PATCH v2] Fix testcase failure when extended attributes are in use Message-ID: <20081014021016.GB14994@riemann.deskinm.fdns.net> In-Reply-To: <20081011154107.GA14994@riemann.deskinm.fdns.net> 06cbe855 (Make core.sharedRepository more generic, 2008-04-16) made several testcases in t1301-shared-repo.sh which fail if on a system which creates files with extended attributes (e.g. SELinux), since ls appends a '+' sign to the permission set in such cases. This fixes the testcase to strip any such sign prior to verifying the permission set. Signed-off-by: Deskin Miller --- ...and then I discovered Documentation/CodingGuidelines: no ? in regular expressions. I really need to learn these shell variable-manipulation builtins. Apologies if for some reason the previous version got used, I haven't seen it anywhere, however. Deskin Miller t/t1301-shared-repo.sh | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/t/t1301-shared-repo.sh b/t/t1301-shared-repo.sh index dc85e8b..4d2db62 100755 --- a/t/t1301-shared-repo.sh +++ b/t/t1301-shared-repo.sh @@ -84,6 +84,7 @@ do git update-server-info && actual="$(ls -l .git/info/refs)" && actual=${actual%% *} && + actual=${actual%+} && test "x$actual" = "x-$y" || { ls -lt .git/info false @@ -97,6 +98,7 @@ do git update-server-info && actual="$(ls -l .git/info/refs)" && actual=${actual%% *} && + actual=${actual%+} && test "x$actual" = "x-$x" || { ls -lt .git/info false -- 1.6.0.2.514.g23abd3