git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Fwd: git status options feature suggestion

From
Jeff King <peff@peff.net>
Date
Oct 13, 2008, 01:04 UTC
Message-ID
<20081013010415.GB3768@coredump.intra.peff.net>
In-Reply-To
<7v1vymgrom.fsf@gitster.siamese.dyndns.org>
On Sun, Oct 12, 2008 at 01:10:01AM -0700, Junio C Hamano wrote:
Show 5 quoted lines
> One thing to keep in mind is what to do when you would want to detect
> renames.  The parallel walk would be Ok but between HEAD and index there
> could be renames involved, and at that point it would get quite tricky.
> Once the index is in-core, I think it hurts us much to walk HEAD vs index
> and index vs working tree in separate passes.

Assuming you meant "I _don't_ think it hurts us much" then OK, that makes sense. I was just thinking it would be more elegant than holding each list in memory and comparing, but really that is not all that different than what diffcore does with the output queue.

> I think it is perfectly fine to run the diff-index first, and keep the
> result from it in a string_list, and then run "diff-files" and annotate
> the string_list with the output from it.

Thanks, I think that is a sane direction to go in. And I agree that any solution should be totally split from the actual output format, so we can reuse it in "git status" if desired.

However, now that Shawn has revealed the existence of his super-secret status replacement, I am going to wait to see that before moving any further. :)

-Peff
Previous: Junio C HamanoNext: Shawn O. Pearce
Message 13 of 29 in “git status options feature suggestion”
  1. Caleb CushingOct 9, 2008
  2. Jeff KingOct 9, 2008
  3. Fwd: git status options feature suggestionCaleb Cushing, Oct 9, 2008
  4. Johannes SchindelinOct 9, 2008
  5. Michael J GruberOct 9, 2008
  6. Caleb CushingOct 10, 2008
  7. Elijah NewrenOct 10, 2008
  8. Johannes SchindelinOct 10, 2008
  9. Jeff KingOct 12, 2008
  10. Junio C HamanoOct 12, 2008
  11. Jeff KingOct 12, 2008
  12. Junio C HamanoOct 12, 2008
  13. Jeff KingOct 13, 2008
  14. Shawn O. PearceOct 13, 2008
  15. Junio C HamanoOct 26, 2008
  16. Jeff KingOct 26, 2008
  17. Shawn O. PearceOct 12, 2008
  18. Jeff KingOct 13, 2008
  19. Jakub NarebskiOct 12, 2008
  20. Wincent ColaiutaOct 12, 2008
  21. Teemu LikonenOct 12, 2008
  22. Andreas EricssonOct 12, 2008
  23. Jeff KingOct 12, 2008
  24. Junio C HamanoOct 12, 2008
  25. Jeff KingOct 13, 2008
  26. ls-files [Was: Re: Fwd: git status options feature suggestion]James Cloos, Oct 9, 2008
  27. Shawn O. PearceOct 9, 2008
  28. Jeremy RamerOct 9, 2008
  29. James CloosOct 9, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.