Re: [PATCH] Implement git clone -v

From: Alex Riesen <raa.lkml@gmail.com>
Date: Oct 8, 2008, 06:25 UTC
Message-ID: <20081008062529.GA4028@blimp.localhost>
In-Reply-To: <20081008060257.GA15240@spearce.org>

Shawn O. Pearce, Wed, Oct 08, 2008 08:02:57 +0200:

Show 16 quoted lines

> Miklos Vajna <vmiklos@frugalware.org> wrote:
> > On Tue, Oct 07, 2008 at 08:21:28AM +0200, Alex Riesen <raa.lkml@gmail.com> wrote:
> > > Yes. Does it work? :)
> > 
> > Yes, it does. I'm not sure how to test it from the testsuite, maybe
> > redirect the output to a file and grep in it? It's ugly, that's why I
> > did not do so, but if you think a testcase is a musthave for this
> > feature then that's the way to go, I guess.
> 
> Actually its not a bad way to test the feature.  Normally we disable
> progress if stdout is not a tty.  If you redirect to a file then
> -v should be needed to get anything at all on stderr.
> 
> You may be able to just test the size of the file:
> 
> 	git fetch -v ... >out 2>err &&

git clone

> 	test -s err

Right, but I don't think you need tests for progress bar. As a typical eye candy, it tends to change often enough to be too annoying to test.