Re: [PATCH] Implement git clone -v

From: Shawn O. Pearce <spearce@spearce.org>
Date: Oct 8, 2008, 06:02 UTC
Message-ID: <20081008060257.GA15240@spearce.org>
In-Reply-To: <20081007193956.GB536@genesis.frugalware.org>

Miklos Vajna <vmiklos@frugalware.org> wrote:

Show 7 quoted lines

> On Tue, Oct 07, 2008 at 08:21:28AM +0200, Alex Riesen <raa.lkml@gmail.com> wrote:
> > Yes. Does it work? :)
> 
> Yes, it does. I'm not sure how to test it from the testsuite, maybe
> redirect the output to a file and grep in it? It's ugly, that's why I
> did not do so, but if you think a testcase is a musthave for this
> feature then that's the way to go, I guess.

Actually its not a bad way to test the feature. Normally we disable progress if stdout is not a tty. If you redirect to a file then -v should be needed to get anything at all on stderr.

You may be able to just test the size of the file:

	git fetch -v ... >out 2>err &&
	test -s err

-- 
Shawn.