git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rebase -i: proper prepare-commit-msg hook argument when squashing

From
Jeff King <peff@peff.net>
Date
Oct 3, 2008, 06:01 UTC
Message-ID
<20081003060110.GA4473@coredump.intra.peff.net>
In-Reply-To
<1222992501-943-1-git-send-email-szeder@ira.uka.de>
On Fri, Oct 03, 2008 at 02:08:21AM +0200, SZEDER Gábor wrote:
> +			cp -v "$MSG" "$GIT_DIR"/SQUASH_MSG

Sorry, but "cp -v" is not portable. It's not in POSIX, and this breaks the script for (at least) Solaris.

However, it's not even clear to me why "-v" is used at all, considering that the "squash" case above does not use it. Is it a debugging leftover? Am I missing something?

[Aside: My Solaris 8 autobuilder is now running, which was a huge pain. However, it is very satisfying to catch things like this in "next" before they hit a wider audience.]

-Peff
Previous: SZEDER GáborNext: SZEDER Gábor
Message 2 of 3 in “rebase -i: proper prepare-commit-msg hook argument when squashing”
  1. rebase -i: proper prepare-commit-msg hook argument when squashingSZEDER Gábor, Oct 3, 2008
  2. Jeff KingOct 3, 2008
  3. rebase -i: remove leftover debuggingSZEDER Gábor, Oct 3, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.