From: Jeff King <peff@peff.net>
Date: Fri, 03 Oct 2008 06:01:10 GMT
Subject: Re: [PATCH] rebase -i: proper prepare-commit-msg hook argument when squashing
Message-ID: <20081003060110.GA4473@coredump.intra.peff.net>
In-Reply-To: <1222992501-943-1-git-send-email-szeder@ira.uka.de>

On Fri, Oct 03, 2008 at 02:08:21AM +0200, SZEDER Gábor wrote:

> +			cp -v "$MSG" "$GIT_DIR"/SQUASH_MSG

Sorry, but "cp -v" is not portable. It's not in POSIX, and this breaks
the script for (at least) Solaris.

However, it's not even clear to me why "-v" is used at all, considering
that the "squash" case above does not use it. Is it a debugging
leftover? Am I missing something?

[Aside: My Solaris 8 autobuilder is now running, which was a huge pain.
However, it is very satisfying to catch things like this in "next"
before they hit a wider audience.]

-Peff