Re: [PATCH] usage.c: remove unused functions

From: Thomas Rast <trast@student.ethz.ch>
Date: Sep 25, 2008, 11:48 UTC
Message-ID: <200809251348.42789.trast@student.ethz.ch>
In-Reply-To: <20080925184104.6117@nanako3.lavabit.com>

Nanako Shiraishi wrote:

> This removes three functions that are not used anywhere.

[...]

> -void set_usage_routine(void (*routine)(const char *err) NORETURN)

[...]

> -void set_error_routine(void (*routine)(const char *err, va_list params))

[...]

> -void set_warn_routine(void (*routine)(const char *warn, va_list params))

These blame to the following commit:

  commit 39a3f5ea7c0352a530338d30d4e618f6b4db84e4
  Author: Petr Baudis <pasky@suse.cz>
  Date:   Sat Jun 24 04:34:38 2006 +0200

      Customizable error handlers
      
      This patch makes the usage(), die() and error() handlers customizable.
      Nothing in the git code itself uses that but many other libgit users
      (like Git.pm) will.
  [...]

So apparently the intent was that they would only be used from outside Git. I don't know whether anyone still plans to do that, but they're certainly not "just" unused.

- Thomas

-- 
Thomas Rast
trast@student.ethz.ch