Re: [PATCH] usage.c: remove unused functions

From: Petr Baudis <pasky@suse.cz>
Date: Sep 25, 2008, 12:48 UTC
Message-ID: <20080925124836.GI10360@machine.or.cz>
In-Reply-To: <200809251348.42789.trast@student.ethz.ch>

On Thu, Sep 25, 2008 at 01:48:37PM +0200, Thomas Rast wrote:

Show 25 quoted lines

> Nanako Shiraishi wrote:
> > This removes three functions that are not used anywhere.
> [...]
> > -void set_usage_routine(void (*routine)(const char *err) NORETURN)
> [...]
> > -void set_error_routine(void (*routine)(const char *err, va_list params))
> [...]
> > -void set_warn_routine(void (*routine)(const char *warn, va_list params))
> 
> These blame to the following commit:
> 
>   commit 39a3f5ea7c0352a530338d30d4e618f6b4db84e4
>   Author: Petr Baudis <pasky@suse.cz>
>   Date:   Sat Jun 24 04:34:38 2006 +0200
> 
>       Customizable error handlers
>       
>       This patch makes the usage(), die() and error() handlers customizable.
>       Nothing in the git code itself uses that but many other libgit users
>       (like Git.pm) will.
>   [...]
> 
> So apparently the intent was that they would only be used from outside
> Git.  I don't know whether anyone still plans to do that, but they're
> certainly not "just" unused.

I don't think it will be a big deal to remove these functions, though it does feel like a little bit of a step backwards in the libgit efforts. There are some programs that already link to Git, like CGit - I wonder if some of them don't use them (CGit itself doesn't).

-- 
				Petr "Pasky" Baudis
People who take cold baths never have rheumatism, but they have
cold baths.