git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] maint: check return of split_cmdline to avoid bad config strings

From
Miklos Vajna <vmiklos@frugalware.org>
Date
Sep 24, 2008, 22:32 UTC
Message-ID
<20080924223252.GL23137@genesis.frugalware.org>
In-Reply-To
<20080924145029.GA3052@riemann.deskinm.fdns.net>
On Wed, Sep 24, 2008 at 10:50:29AM -0400, Deskin Miller <deskinm@umich.edu> wrote:
Show 6 quoted lines
> As the testcase demonstrates, it's possible for split_cmdline to return -1 and
> deallocate any memory it's allocated, if the config string is missing an end
> quote.  In both the cases below, which are the only calling sites, the return
> isn't checked, and using the pointer causes a pretty immediate segfault.
> 
> Signed-off-by: Deskin Miller <deskinm@umich.edu>
Acked-by: Miklos Vajna <vmiklos@frugalware.org>
Thanks.
Previous: Deskin Miller
Message 4 of 4 in “maint: check return of split_cmdline to avoid bad config strings”
  1. maint: check return of split_cmdline to avoid bad config stringsDeskin Miller, Sep 24, 2008
  2. Miklos VajnaSep 24, 2008
  3. Deskin MillerSep 24, 2008
  4. Miklos VajnaSep 24, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.