From: Miklos Vajna <vmiklos@frugalware.org>
Date: Wed, 24 Sep 2008 22:32:52 GMT
Subject: Re: [PATCH v2] maint: check return of split_cmdline to avoid bad config strings
Message-ID: <20080924223252.GL23137@genesis.frugalware.org>
In-Reply-To: <20080924145029.GA3052@riemann.deskinm.fdns.net>

On Wed, Sep 24, 2008 at 10:50:29AM -0400, Deskin Miller <deskinm@umich.edu> wrote:
> As the testcase demonstrates, it's possible for split_cmdline to return -1 and
> deallocate any memory it's allocated, if the config string is missing an end
> quote.  In both the cases below, which are the only calling sites, the return
> isn't checked, and using the pointer causes a pretty immediate segfault.
> 
> Signed-off-by: Deskin Miller <deskinm@umich.edu>

Acked-by: Miklos Vajna <vmiklos@frugalware.org>

Thanks.