Re: [JGIT PATCH 1/2] Switch usage of AnyObjectId.toString() to new AnyObjectId.name()

From: Shawn O. Pearce <spearce@spearce.org>
Date: Sep 4, 2008, 03:23 UTC
Message-ID: <20080904032358.GB3262@spearce.org>
In-Reply-To: <20080903213114.GA6316@diku.dk>

Jonas Fonseca <fonseca@diku.dk> wrote:

Show 15 quoted lines

> Shawn O. Pearce <spearce@spearce.org> wrote Wed, Sep 03, 2008:
> > Hmm.  I had to squash this into it just to fix most of the code and
> > make it pass tests, let alone fix the fetch and push implementations.
> > Most of the library plain up and broke with this toString change.
> >
> > Missing T0001_ObjectId suggests to me that your method of running
> > the tests isn't working right.
> 
> I can see that I am off to a good start leaving everything in a nice
> broken mess. My only excuse is that while writing the patch I was still
> trying to set up the tests to run properly. After applying your fix
> and rerunning the tests pass here also.
> 
> And, lessons learnt: also run the jgit programs to get wider coverage.
> (Uh, sounds like wiki material ... :)

No big deal.  The jgit pgm package has no tests.  It needs tests.
Running them by hand to test the sucks.  Really I was just trying
to make you aware of the fact that your test runner wasn't working
correctly.

Show 7 quoted lines

> > And this is only JGit.  I haven't even started to look into EGit.
> > Though I don't expect you to fix EGit since you are working on
> > NetBeans.  :-)
> 
> It is clearly a bigger tasks than I had expected and maybe not a good
> starting point for contributing to JGit. However, in the longer run this
> interface change will remove some unpleasant surprises.

Robin filled in the EGit stuff. I'll go through it again once more tomorrow and hopefully we can apply the whole series and move on.

-- 
Shawn.