git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [JGIT PATCH 1/2] Switch usage of AnyObjectId.toString() to new AnyObjectId.name()

From
Jonas Fonseca <fonseca@diku.dk>
Date
Sep 3, 2008, 21:31 UTC
Message-ID
<20080903213114.GA6316@diku.dk>
In-Reply-To
<20080903170438.GA28315@spearce.org>
Shawn O. Pearce <spearce@spearce.org> wrote Wed, Sep 03, 2008:
Show 6 quoted lines
> Hmm.  I had to squash this into it just to fix most of the code and
> make it pass tests, let alone fix the fetch and push implementations.
> Most of the library plain up and broke with this toString change.
>
> Missing T0001_ObjectId suggests to me that your method of running
> the tests isn't working right.

I can see that I am off to a good start leaving everything in a nice broken mess. My only excuse is that while writing the patch I was still trying to set up the tests to run properly. After applying your fix and rerunning the tests pass here also.

And, lessons learnt: also run the jgit programs to get wider coverage. (Uh, sounds like wiki material ... :)

> And this is only JGit.  I haven't even started to look into EGit.
> Though I don't expect you to fix EGit since you are working on
> NetBeans.  :-)

It is clearly a bigger tasks than I had expected and maybe not a good starting point for contributing to JGit. However, in the longer run this interface change will remove some unpleasant surprises.

-- 
Jonas Fonseca
Previous: Shawn O. PearceNext: Shawn O. Pearce
Message 7 of 8 in “Switch usage of AnyObjectId.toString() to new AnyObjectId.name()”
  1. 1/2 Switch usage of AnyObjectId.toString() to new AnyObjectId.name()Jonas Fonseca, Sep 3, 2008
  2. Shawn O. PearceSep 3, 2008
  3. 3/4 Switch usage of AnyObjectId.toString() to new AnyObjectId.name() in Eclipse pluginRobin Rosenberg, Sep 3, 2008
  4. 4/4 Switch usage of AnyObjectId.toString() to new AnyObjectId.name()Robin Rosenberg, Sep 3, 2008
  5. Robin RosenbergSep 3, 2008
  6. Shawn O. PearceSep 3, 2008
  7. Jonas FonsecaSep 3, 2008
  8. Shawn O. PearceSep 4, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.