git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCH 1/2] for-each-ref: add new format 'refbasename'

From
Shawn O. Pearce <spearce@spearce.org>
Date
Aug 29, 2008, 14:34 UTC
Message-ID
<20080829143448.GC7403@spearce.org>
In-Reply-To
<0329f1ab2642e1dab701b5fc6517bfb1b4ea2d46.1220004755.git.szeder@ira.uka.de>
SZEDER GGGbor <szeder@ira.uka.de> wrote:
Show 20 quoted lines
> Therefore, we introduce a new for-each-ref format called 'refbasename',
> which strips everything before and including the second '/' in the ref's
> name from the output.
> 
>   I assumed that refs always look like 'refs/{heads,tags,whatever}/foo',
>   hence this patch breaks if a ref might look like 'refs/foo' or just
>   'foo'.  But can I really rely on that?
> 
> diff --git a/builtin-for-each-ref.c b/builtin-for-each-ref.c
> index 21e92bb..1993ff4 100644
> --- a/builtin-for-each-ref.c
> +++ b/builtin-for-each-ref.c
> @@ -577,6 +578,10 @@ static void populate_value(struct refinfo *ref)
>  			char *s = xmalloc(len + 4);
>  			sprintf(s, "%s^{}", ref->refname);
>  			v->s = s;
> +		} else if (!strcmp(name, "refbasename")) {
> +			char * p = strchr(ref->refname, '/');
> +			p = strchr(p+1, '/');
> +			v->s = p+1;

Please be careful here and check for !p. A refname may be missing one or two '/' in which case you will cause the process to segfault.

I don't think its a good idea to assume you'll always have to '/' in the name. "refs/foo" can be created by git-update-ref. Or if we ever started to report on HEAD this output tag would crash.

Also, as a style nit, its "p + 1" not "p+1".
Test cases?

On the other hand, I like where this is going. Given that it has such a nice effect on the bash completion for larger repos I'd like to see it in Git.

-- 
Shawn.
Previous: SZEDER GáborNext: SZEDER Gábor
Message 3 of 8 in “for-each-ref: add new format 'refbasename'”
  1. 1/2 for-each-ref: add new format 'refbasename'SZEDER Gábor, Aug 29, 2008
  2. 2/2 bash: use for-each-ref format 'refbasename'SZEDER Gábor, Aug 29, 2008
  3. Shawn O. PearceAug 29, 2008
  4. 1/2 for-each-ref: add new format 'refbasename'SZEDER Gábor, Aug 29, 2008
  5. Bert WesargAug 29, 2008
  6. for-each-ref: new 'refshort' formatBert Wesarg, Aug 29, 2008
  7. Junio C HamanoAug 31, 2008
  8. Bert WesargAug 31, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.