Re: [JGIT PATCH] Typo in implementation of pack protocol

From: H.Merijn Brand <h.m.brand@xs4all.nl>
Date: Aug 21, 2008, 15:02 UTC
Message-ID: <20080821170200.3ea08b28@pc09.procura.nl>
In-Reply-To: <20080821170042.457e62f1@pc09.procura.nl>

On Thu, 21 Aug 2008 17:00:42 +0200, "H.Merijn Brand" <h.m.brand@xs4all.nl> wrote:

Show 16 quoted lines

> On Thu, 21 Aug 2008 07:50:12 -0700, "Shawn O. Pearce"
> <spearce@spearce.org> wrote:
> 
> > Mike Ralphson <mike@abacus.co.uk> wrote:
> > > cgit's receive-pack.c has never had the corresponding typo.
> > > Fix up method and member names to match.
> > 
> > Whoops.  Thanks.
> >  
> > > -				if (line.equals("capabilties^{}")) {
> > > +				if (line.equals("capabilities^{}")) {
> > >  					// special line from git-receive-pack to show
> > >  					// capabilities when there are no refs to advertise
> 
> Wouldn't it be nice to stick to ANSI Comments?
> I bet AIX xlc will fall over very very fast here

Ignore that stupid remark. It's java :(

-- 
H.Merijn Brand          Amsterdam Perl Mongers  http://amsterdam.pm.org/
using & porting perl 5.6.2, 5.8.x, 5.10.x, 5.11.x on HP-UX 10.20, 11.00,
11.11, 11.23, and 11.31, SuSE 10.1, 10.2, and 10.3, AIX 5.2, and Cygwin.
http://mirrors.develooper.com/hpux/           http://www.test-smoke.org/
http://qa.perl.org      http://www.goldmark.org/jeff/stupid-disclaimers/