Re: [JGIT PATCH] Typo in implementation of pack protocol

From: Shawn O. Pearce <spearce@spearce.org>
Date: Aug 21, 2008, 15:02 UTC
Message-ID: <20080821150214.GQ3483@spearce.org>
In-Reply-To: <20080821170042.457e62f1@pc09.procura.nl>

"H.Merijn Brand" <h.m.brand@xs4all.nl> wrote:

Show 16 quoted lines

> On Thu, 21 Aug 2008 07:50:12 -0700, "Shawn O. Pearce"
> <spearce@spearce.org> wrote:
> 
> > Mike Ralphson <mike@abacus.co.uk> wrote:
> > > cgit's receive-pack.c has never had the corresponding typo.
> > > Fix up method and member names to match.
> > 
> > Whoops.  Thanks.
> >  
> > > -				if (line.equals("capabilties^{}")) {
> > > +				if (line.equals("capabilities^{}")) {
> > >  					// special line from git-receive-pack to show
> > >  					// capabilities when there are no refs to advertise
> 
> Wouldn't it be nice to stick to ANSI Comments?
> I bet AIX xlc will fall over very very fast here

AIX xlc compiles Java code?

This is JGIT, written in Java, not git.git, written in ANSI C...

-- 
Shawn.