git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [EGIT PATCH 2/2] Honor ~/.ssh/config whenever possible during SSH based transport

From
Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Date
Aug 20, 2008, 20:34 UTC
Message-ID
<200808202234.08348.robin.rosenberg.lists@dewire.com>
In-Reply-To
<1218821705-2631-2-git-send-email-spearce@spearce.org>
fredagen den 15 augusti 2008 19.35.05 skrev Shawn O. Pearce:
Show 6 quoted lines
> +	private void addIdentity(final File identityFile)
> +			throws JSchException {
> +		final String path = identityFile.getAbsolutePath();
> +		if (loadedIdentities.add(path))
> +			provider.getJSch().addIdentity(path);
>  	}

Ok, this breaks 3.3 compatibility and I accidentally pushed it to master. Now Marek also has stuff that only works (well) with 3.4 becaujse of bugs in 3.3, that won't be fixed. So maybe we'd better skip 3.3 in order to work faster. I.e. I won't revert this commit, but I am willing to accept a patch to "fix" it in order to prolong 3.3 compatibilty.

-- robin
Previous: Shawn O. PearceNext: Shawn O. Pearce
Message 3 of 4 in “Refactor SSH key loading so we don't duplicate keys”
  1. 1/2 Refactor SSH key loading so we don't duplicate keysShawn O. Pearce, Aug 15, 2008
  2. 2/2 Honor ~/.ssh/config whenever possible during SSH based transportShawn O. Pearce, Aug 15, 2008
  3. Robin RosenbergAug 20, 2008
  4. Shawn O. PearceAug 20, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.