Re: [EGIT PATCH 2/2] Honor ~/.ssh/config whenever possible during SSH based transport
- From
Shawn O. Pearce <spearce@spearce.org>
- Date
- Aug 20, 2008, 20:38 UTC
- Message-ID
- <20080820203818.GL3483@spearce.org>
- In-Reply-To
- <200808202234.08348.robin.rosenberg.lists@dewire.com>
Robin Rosenberg <robin.rosenberg.lists@dewire.com> wrote:
Show 12 quoted lines
> fredagen den 15 augusti 2008 19.35.05 skrev Shawn O. Pearce:
> > + private void addIdentity(final File identityFile)
> > + throws JSchException {
> > + final String path = identityFile.getAbsolutePath();
> > + if (loadedIdentities.add(path))
> > + provider.getJSch().addIdentity(path);
> > }
>
> Ok, this breaks 3.3 compatibility and I accidentally pushed it to master. Now Marek also
> has stuff that only works (well) with 3.4 becaujse of bugs in 3.3, that won't be fixed. So maybe
> we'd better skip 3.3 in order to work faster. I.e. I won't revert this commit, but I am willing to
> accept a patch to "fix" it in order to prolong 3.3 compatibilty.I agree. But I'm not going to be supplying that fix myself. I don't want to spend a lot of time messing around with the SSH transport, that was just annoying me one morning.
-- Shawn.