git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Allow emails with boundaries to work again

From
DZDon Zickus <dzickus@redhat.com>
Date
Aug 14, 2008, 01:56 UTC
Message-ID
<20080814015604.GD24172@redhat.com>
In-Reply-To
<7vtzdogyx6.fsf@gitster.siamese.dyndns.org>
On Wed, Aug 13, 2008 at 06:36:53PM -0700, Junio C Hamano wrote:
Show 13 quoted lines
> Don Zickus <dzickus@redhat.com> writes:
> 
> > Recent changes to is_multipart_boundary() caused git-mailinfo to segfault.
> > The reason was after handling the end of the boundary the code tried to look
> > for another boundary.  Because the boundary list was empty, dereferencing
> > the pointer to the top of the boundary caused the program to go boom.
> >
> > The fix is to check to see if the list is empty and if so go on its merry
> > way instead of looking for another boundary.
> 
> Hmm, at this point !*content_top means that we are at the outermost level
> and we have just seen --boundary-- which is the terminating one, haven't
> we?  Shouldn't we be simply returning?

That's what I originally did, but then I realized the rest of the handle_boundary() reads the next line of text, which is needed to continue processing in handle_body(). :-)

Cheers, Don

Previous: Junio C Hamano
Message 5 of 5 in “Allow emails with boundaries to work again”
  1. Allow emails with boundaries to work againDon Zickus, Aug 13, 2008
  2. Junio C HamanoAug 13, 2008
  3. Don ZickusAug 14, 2008
  4. Junio C HamanoAug 14, 2008
  5. Don ZickusAug 14, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.