Re: [PATCH] Allow emails with boundaries to work again
- From
- Don Zickus <dzickus@redhat.com>
- Date
- Aug 14, 2008, 00:56 UTC
- Message-ID
- <20080814005631.GC24172@redhat.com>
- In-Reply-To
- <7vbpzwjx8d.fsf@gitster.siamese.dyndns.org>
On Wed, Aug 13, 2008 at 04:45:06PM -0700, Junio C Hamano wrote:
Show 9 quoted lines
> Don Zickus <dzickus@redhat.com> writes: > > > Recent changes to is_multipart_boundary() caused git-mailinfo to segfault. > > The reason was after handling the end of the boundary the code tried to look > > for another boundary. Because the boundary list was empty, dereferencing > > the pointer to the top of the boundary caused the program to go boom. > > We keep fixing and breaking this thing, don't we? Can we have a testcase > to protect this codepath?
Heh. Ok I will try to work on one for tomorrow.
Cheers, Don