git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] builtin-reflog: fix deletion of HEAD entries

From
Johannes Sixt <johannes.sixt@telecom.at>
Date
Aug 10, 2008, 11:12 UTC
Message-ID
<200808101312.48213.johannes.sixt@telecom.at>
In-Reply-To
<1218360901-36215-1-git-send-email-pdebie@ai.rug.nl>
On Sonntag, 10. August 2008, Pieter de Bie wrote:
Show 23 quoted lines
> diff --git a/builtin-reflog.c b/builtin-reflog.c
> index 5af3f28..a8311a6 100644
> --- a/builtin-reflog.c
> +++ b/builtin-reflog.c
> @@ -541,14 +541,15 @@ static int cmd_reflog_expire(int argc, const char
> **argv, const char *prefix) }
>
>  	while (i < argc) {
> -		const char *ref = argv[i++];
> +		char *ref;
>  		unsigned char sha1[20];
> -		if (!resolve_ref(ref, sha1, 1, NULL)) {
> -			status |= error("%s points nowhere!", ref);
> +		if (!dwim_log(argv[i], strlen(argv[i]), sha1, &ref)) {
> +			status |= error("%s points nowhere!", argv[i]);
>  			continue;
>  		}
>  		set_reflog_expiry_param(&cb, explicit_expiry, ref);
>  		status |= expire_reflog(ref, sha1, 0, &cb);
> +		i++;
>  	}
>  	return status;
>  }

This runs into an endless loop in the error case because it doesn't increase i.

-- Hannes
Previous: Pieter de BieNext: Junio C Hamano
Message 6 of 9 in “reflog test: add more tests for 'reflog delete'”
  1. 1/2 reflog test: add more tests for 'reflog delete'Pieter de Bie, Aug 9, 2008
  2. 2/2 builtin-reflog: fix deletion of HEAD entriesPieter de Bie, Aug 9, 2008
  3. Junio C HamanoAug 10, 2008
  4. Junio C HamanoAug 10, 2008
  5. Pieter de BieAug 10, 2008
  6. Johannes SixtAug 10, 2008
  7. Junio C HamanoAug 10, 2008
  8. Pieter de BieAug 10, 2008
  9. builtin-reflog: Allow reflog expire to name partial refPieter de Bie, Aug 10, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.