Re: [PATCH] git-svn.perl: Strip ChangeLog bits.
- From
- Eric Wong <normalperson@yhbt.net>
- Date
- Aug 4, 2008, 09:03 UTC
- Message-ID
- <20080804090309.GD5435@hand.yhbt.net>
- In-Reply-To
- <1217836189.7649.7.camel@heerbeest>
Jan Nieuwenhuizen <janneke-list@xs4all.nl> wrote:
Show 24 quoted lines
> On zo, 2008-08-03 at 19:09 -0700, Eric Wong wrote: > > > Jan Nieuwenhuizen <janneke-list@xs4all.nl> wrote: > > > I could imagine that leaving git-svn alone and adding a hook to git-log > > > would be more useful, though. > > > > NACK on modifying git-svn to support more changelog formats. > > > > A better idea would be to write a generic script that takes "git log", > > "git svn log" or even plain "svn log" output and filters it > > independently. > > > This filter should be reusable for both plain svn and git-svn: > > > The possibilities are endless :) > > Yes, but we'll most probably drop SVN rsn, possibly after a short period > of supporting both; and not stripping the cruft in the conversion means > we carry this with us until eternity. Besides, who is going to > distribute the script, inform users about its availability? > > What we have now suffices for our ooo-build conversion. If you do not > find it useful, more power/less code to you. Let others search the > archives and/or patch git-svn themselves, if indeed there are any.
In the one-shot case, a git filter-branch script would probably be ideal and reusable for other projects.
Anyways, I strongly believe changelog modification/reformatting should be done in a more generic way that can benefit users of other tools (archimport/cvsimport etc...), too.
-- Eric Wong