Re: [PATCH] git-svn.perl: Strip ChangeLog bits.
- From
- Jan Nieuwenhuizen <janneke-list@xs4all.nl>
- Date
- Aug 2, 2008, 18:17 UTC
- Message-ID
- <1217701021.8296.35.camel@heerbeest>
- In-Reply-To
- <7vfxpnnwt5.fsf@gitster.siamese.dyndns.org>
On za, 2008-08-02 at 10:36 -0700, Junio C Hamano wrote:
Show 6 quoted lines
> > You forgot to document your option. (And possibly write a testcase.)
>
> I am not sure if this is generic enough to be in git-svn.perl itself, or
> perhaps there should be a hook make_log_entry() would call in the form of
> some Perl scriptlet given by the user to munge $log_entry{log}, which
> would be very specific to each project.If you're not sure, please make up your mind. I agree it's quite a hack but now it's in the archives for others to find. Doing this in a single regexp is a bit tricky and asking a user to write a perl snippet is even worse, imho. Especially if would turn out that stripping changelog bits is the only thing that the hook is getting used for, in the end. I have gotten more careful to provide generic solutions to specific problems in anticipation of possible future desires.
I could imagine that leaving git-svn alone and adding a hook to git-log would be more useful, though.
Jan.
-- Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond - The music typesetter http://www.xs4all.nl/~jantien | http://www.lilypond.org