Re: [PATCH] Git.pm: Fix internal git_command_bidi_pipe() users

From: Petr Baudis <pasky@suse.cz>
Date: Aug 4, 2008, 08:21 UTC
Message-ID: <20080804082117.GI10151@machine.or.cz>
In-Reply-To: <7vtze12oij.fsf@gitster.siamese.dyndns.org>

On Mon, Aug 04, 2008 at 01:05:56AM -0700, Junio C Hamano wrote:

Show 15 quoted lines

> Petr Baudis <pasky@suse.cz> writes:
> 
> > The hash_and_insert_object() and cat_blob() helpers were using
> > an incorrect slice-from-ref Perl syntax. This patch fixes that up
> > in the _close_*() helpers and make the _open_*() helpers use the
> > same syntax for consistnecy.
> >
> > Signed-off-by: Petr Baudis <pasky@suse.cz>
> > ---
> >
> >   Wow, the command_bidi_pipe API really is dirty. Of course, it is
> > my fault as anyone's since I didn't get around to review the patches
> > introducing it.
> 
> Sorry, delete is still broken with your patch, isn't it?

Oh, right - I forgot that one and it didn't occur to me to test this part.

> The earlier patch from Abhijit Menon-Sen does this properly for
> close_hash_and_insert and close_cat_blob, which I've queued already.

Abhijit, can you please tag your Git.pm patches so that I actually have a chance to see and review it?

Thanks,

				Petr "Pasky" Baudis