git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Fix hash slice syntax error

From
AMAbhijit Menon-Sen <ams@toroid.org>
Date
Aug 4, 2008, 05:02 UTC
Message-ID
<20080804050247.GA13539@toroid.org>
In-Reply-To
<be6fef0d0808032149p651309a8o773dca5f16923ee1@mail.gmail.com>
Signed-off-by: Abhijit Menon-Sen <ams@toroid.org>
---
At 2008-08-04 12:49:27 +0800, rctay89@gmail.com wrote:
>
> $self->{@vars} evaluates to undef. i can't find any mention of using
> arrays to dereference objects in the manual and elsewhere; is this a
> mistake?

Yes, @vars would be interpreted in scalar context, which certainly isn't the intended effect.

-- ams
 perl/Git.pm |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/perl/Git.pm b/perl/Git.pm
index 087d3d0..2ef437f 100644
--- a/perl/Git.pm
+++ b/perl/Git.pm
@@ -839,8 +839,8 @@ sub _close_hash_and_insert_object {
 
 	my @vars = map { 'hash_object_' . $_ } qw(pid in out ctx);
 
-	command_close_bidi_pipe($self->{@vars});
-	delete $self->{@vars};
+	command_close_bidi_pipe(@$self{@vars});
+	delete @$self{@vars};
 }
 
 =item cat_blob ( SHA1, FILEHANDLE )
@@ -928,8 +928,8 @@ sub _close_cat_blob {
 
 	my @vars = map { 'cat_blob_' . $_ } qw(pid in out ctx);
 
-	command_close_bidi_pipe($self->{@vars});
-	delete $self->{@vars};
+	command_close_bidi_pipe(@$self{@vars});
+	delete @$self{@vars};
 }
 
 =back
-- 
1.6.0.rc0.43.g2aa74
Previous: Ray ChuanNext: Petr Baudis
Message 2 of 9 in “[git/perl] unusual syntax?”
  1. Ray ChuanAug 4, 2008
  2. Fix hash slice syntax errorAbhijit Menon-Sen, Aug 4, 2008
  3. Git.pm: Fix internal git_command_bidi_pipe() usersPetr Baudis, Aug 4, 2008
  4. Junio C HamanoAug 4, 2008
  5. Petr BaudisAug 4, 2008
  6. Junio C HamanoAug 4, 2008
  7. Git.pm: localise $? in command_close_bidi_pipe()Abhijit Menon-Sen, Aug 4, 2008
  8. Junio C HamanoAug 5, 2008
  9. David ChristensenAug 4, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.