git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git blame not respecting --find-copies-harder ?

From
Jeff King <peff@peff.net>
Date
Jul 31, 2008, 07:21 UTC
Message-ID
<20080731072149.GA2304@sigill.intra.peff.net>
In-Reply-To
<7vfxpq3559.fsf@gitster.siamese.dyndns.org>
On Thu, Jul 31, 2008 at 12:05:22AM -0700, Junio C Hamano wrote:
> We can probably pick up the result revision parser parsed out of
> revs.diffopt, and then tweak "opt" with it, perhaps like this.

That is a sensible solution for this option, but I have to wonder: how many other such ineffective options are hiding? How many of them actually have a matching meaning in git-blame? E.g., what does "git blame --name-only" mean?

Perhaps we should simply not worry about those ones, as people are unlikely to try using them, and it is easy to say "has no impact, because it doesn't make sense with blame." The truly confusing ones are ones you _expect_ to do something, but don't (like --find-copies-harder).

I took a look at implementing a "don't parse the diff options" flag, but it is much larger than that. The revision parser understands a lot of options that don't really make sense for blame (or shortlog), like "--full-diff". So perhaps it is best to just fix this one (which we have actually had a bug report about) and not worry about the rest.

-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 6 of 17 in “git blame not respecting --find-copies-harder ?”
  1. Stephen R. van den BergJul 30, 2008
  2. Björn SteinbrinkJul 30, 2008
  3. Sverre RabbelierJul 30, 2008
  4. Jeff KingJul 31, 2008
  5. Junio C HamanoJul 31, 2008
  6. Jeff KingJul 31, 2008
  7. Junio C HamanoJul 31, 2008
  8. Jeff KingJul 31, 2008
  9. Junio C HamanoJul 31, 2008
  10. Pierre HabouzitJul 31, 2008
  11. Jeff KingJul 31, 2008
  12. Pierre HabouzitJul 31, 2008
  13. Jeff KingJul 31, 2008
  14. Pierre HabouzitJul 31, 2008
  15. Jeff KingJul 31, 2008
  16. Pierre HabouzitJul 31, 2008
  17. Jeff KingJul 31, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.