Re: [PATCH (GIT-GUI) 0/3] Improve gui blame usability for large repositories
- From
Alexander Gavrilov <angavrilov@gmail.com>
- Date
- Jul 18, 2008, 05:39 UTC
- Message-ID
- <200807180939.06082.angavrilov@gmail.com>
- In-Reply-To
- <20080717021623.GC16740@spearce.org>
Hello,
On Thursday 17 July 2008 06:16:23 Shawn O. Pearce wrote:
Show 17 quoted lines
> Alexander Gavrilov <angavrilov@gmail.com> wrote: > > Full copy detection can take quite some time on large repositories, which > > substantially decreases perceived usability of the 'git gui blame' command. > > This set of patches tries to overcome it by: > > > > 1) Allowing the user to disable '-C -C' and/or set the detection threshold. > > > > 2) Explicitly killing back-end processes, which don't produce any output > > during copy detection, and thus normally won't receive SIGPIPE until > > it is finished. Runaway processes are annoying. > > > > 3) To compensate for (1), adding a context menu item to manually invoke > > blame -C -C -C on a group of lines. > > This series is nicely done. Works well on revision.c in git.git, > where the blame can be costly to compute with full copy detection. > And getting the incremental from the context menu also works well.
I also thought that it would be useful to be able to specify the line range explicitly, but couldn't invent a good UI for it. Selecting lines with the mouse also causes a commit to be selected and recolored in green, and popping up a dialog to request line numbers seems too lame.
Alexander