Re: [PATCH (GIT-GUI) 0/3] Improve gui blame usability for large repositories
- From
Shawn O. Pearce <spearce@spearce.org>
- Date
- Jul 17, 2008, 02:16 UTC
- Message-ID
- <20080717021623.GC16740@spearce.org>
- In-Reply-To
- <200807170042.29462.angavrilov@gmail.com>
Alexander Gavrilov <angavrilov@gmail.com> wrote:
Show 12 quoted lines
> Full copy detection can take quite some time on large repositories, which > substantially decreases perceived usability of the 'git gui blame' command. > This set of patches tries to overcome it by: > > 1) Allowing the user to disable '-C -C' and/or set the detection threshold. > > 2) Explicitly killing back-end processes, which don't produce any output > during copy detection, and thus normally won't receive SIGPIPE until > it is finished. Runaway processes are annoying. > > 3) To compensate for (1), adding a context menu item to manually invoke > blame -C -C -C on a group of lines.
This series is nicely done. Works well on revision.c in git.git, where the blame can be costly to compute with full copy detection. And getting the incremental from the context menu also works well.
Thanks.
-- Shawn.