git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/v3] bundle.c: added --stdin option to git-bundle

From
Jakub Narebski <jnareb@gmail.com>
Date
Jul 5, 2008, 16:54 UTC
Message-ID
<200807051854.46798.jnareb@gmail.com>
In-Reply-To
<c376da900807050930i6d1da898s624be58adc6f1751@mail.gmail.com>
On Sat, 5 Jul 2008, Adam Brewster wrote:
> It seems that the consensus is that the other half of my original
> patch is no good.  You have some pretty good ideas about how to
> correctly address the problem I was trying to solve, and I look
> forward to seeing them actually implemented.

It is not that the other half is "no good", it is rather that there is no consensus how and in what way it should be implemented; be it separate git-bases command, git-bundle--bases helper script, or incorporated in git-bundle code; should it be written in Perl or as shell script (only in case of git-bases or git-bundle--bases), or should it be written in C.

Adding some documentation, with example usage (example "workflows") would help adding git-bases to git core... perhaps at start send it as script in contrib/ ?

> For now, I offer separately the modification I made to bundle.c to
> allow git-bundle to handle the --stdin option.  

That's the way it is preferred here on git mailing list, to not bundle non-controversial change with the one that needs (or seem to need) some further discussion - do not hold features hostage ;-)

> There is no accompanying change to the documentation because it
> already implies that this option is available.

Adding an example of using `--stdin' to "[git-rev-list-args...]::" in Documentation/git-bundle.txt would be good.

-- 
Jakub Narebski
Poland
Previous: Adam BrewsterNext: Junio C Hamano
Message 2 of 18 in “bundle.c: added --stdin option to git-bundle”
  1. bundle.c: added --stdin option to git-bundleAdam Brewster, Jul 5, 2008
  2. Jakub NarebskiJul 5, 2008
  3. Junio C HamanoJul 5, 2008
  4. 0/3 Adam Brewster, Jul 5, 2008
  5. Move read_revisions_from_stdin from builtin-rev-list.c to revision.cAdam Brewster, Jul 5, 2008
  6. git-bundle: add --stdinAdam Brewster, Jul 5, 2008
  7. Add git-basis.perl to contrib directoryAdam Brewster, Jul 5, 2008
  8. Miklos VajnaJul 5, 2008
  9. Adam Brewster, Jul 5, 2008
  10. Move read_revisions_from_stdin from builtin-rev-list.c to revision.cAdam Brewster, Jul 5, 2008
  11. git-bundle: add --stdinAdam Brewster, Jul 5, 2008
  12. Junio C HamanoJul 6, 2008
  13. Adam BrewsterJul 6, 2008
  14. git-rev-list: tolerate multiple --stdin optionsAdam Brewster, Jul 6, 2008
  15. Teach git-bundle to read revision arguments from stdin likeAdam Brewster, Jul 6, 2008
  16. Junio C HamanoJul 6, 2008
  17. Adam BrewsterJul 6, 2008
  18. Junio C HamanoJul 6, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.