Re: Teach git-bundle to read revision arguments from stdin like git-rev-list

From: Adam Brewster <adambrewster@gmail.com>
Date: Jul 6, 2008, 14:28 UTC
Message-ID: <1215354538-1469-1-git-send-email-adambrewster@gmail.com>
In-Reply-To: <7v63rjrfqz.fsf@gitster.siamese.dyndns.org>

On Sat, Jul 5, 2008 at 8:57 PM, Junio C Hamano <gitster@pobox.com>

>> +                     if (read_from_stdin++)
>> +                             die("--stdin given twice?");
>
> Hmm, do we deeply care about this case?  What bad things coulc happen

if

> you call read_revisions_from_stdin() twice?
>

Presently, it'll actually try to read stdin twice and that won't work.

Also, if you want git-bundle to deal with --stdin --stdin, I'd say that git-rev-list should do the same. I don't really care how this particular error case is handled, but I think git-rev-list and git-bundle should do the same thing for any given input.

If you prefer to be liberal in what you accept, then you might like these two patches that allow git-rev-list and git-bundle to deal with --stdin --stdin.

By the way, I'm not exactly sure on the format of these guys. You said you queued some changes yesterday, so these go on top of those. If you want me to start from scratch and give you the whole chain again, I can do that too.