git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] pre-commit hook should ignore carriage returns at EOL

From
Jeff King <peff@peff.net>
Date
Jun 27, 2008, 04:24 UTC
Message-ID
<20080627042446.GD7144@sigill.intra.peff.net>
In-Reply-To
<7vlk0rokxb.fsf@gitster.siamese.dyndns.org>
On Thu, Jun 26, 2008 at 04:06:56PM -0700, Junio C Hamano wrote:
Show 7 quoted lines
> +if git-rev-parse --verify HEAD 2>/dev/null
> +then
> +	against=
> +else
> +	# Initial commit: diff against an empty tree object
> +	against=4b825dc642cb6eb9a060e54bf8d69288fbee4904
> +fi

Heh, I am happy that the virtual empty tree object is coming in handy again.

>From quick review, the series looks good to me (and it was, btw, very

easy to read -- I think that you, as somebody who reviews a lot of patches, have gotten very good at splitting up your own sensibly. :) ).

-Peff
Previous: Junio C Hamano
Message 14 of 14 in “pre-commit hook should ignore carriage returns at EOL”
  1. pre-commit hook should ignore carriage returns at EOLChristian Holtje, Jun 24, 2008
  2. Alex RiesenJun 25, 2008
  3. Christian HoltjeJun 25, 2008
  4. Junio C HamanoJun 25, 2008
  5. Christian HoltjeJun 26, 2008
  6. Junio C HamanoJun 26, 2008
  7. 1/5 diff --check: explain why we do not care whether old side is binaryJunio C Hamano, Jun 26, 2008
  8. 2/5 check_and_emit_line(): rename and refactorJunio C Hamano, Jun 26, 2008
  9. 3/5 checkdiff: pass diff_options to the callbackJunio C Hamano, Jun 26, 2008
  10. 4/5 Teach "diff --check" about a new blank lines at endJunio C Hamano, Jun 26, 2008
  11. 5/5 diff --check: detect leftover conflict markersJunio C Hamano, Jun 26, 2008
  12. Junio C HamanoJun 26, 2008
  13. Junio C HamanoJun 26, 2008
  14. Jeff KingJun 27, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.