From: Jeff King <peff@peff.net>
Date: Fri, 27 Jun 2008 04:24:46 GMT
Subject: Re: [PATCH v2] pre-commit hook should ignore carriage returns at EOL
Message-ID: <20080627042446.GD7144@sigill.intra.peff.net>
In-Reply-To: <7vlk0rokxb.fsf@gitster.siamese.dyndns.org>

On Thu, Jun 26, 2008 at 04:06:56PM -0700, Junio C Hamano wrote:

> +if git-rev-parse --verify HEAD 2>/dev/null
> +then
> +	against=
> +else
> +	# Initial commit: diff against an empty tree object
> +	against=4b825dc642cb6eb9a060e54bf8d69288fbee4904
> +fi

Heh, I am happy that the virtual empty tree object is coming in handy
again.

>From quick review, the series looks good to me (and it was, btw, very
easy to read -- I think that you, as somebody who reviews a lot of
patches, have gotten very good at splitting up your own sensibly. :) ).

-Peff