[PATCH 2/2] for-each-ref: implement missing tag values
- From
Jeff King <peff@peff.net>
- Date
- Jun 26, 2008, 05:38 UTC
- Message-ID
- <20080626053804.GB20824@sigill.intra.peff.net>
- In-Reply-To
- <20080626053551.GA20767@sigill.intra.peff.net>
The "type" and "object" fields for tags were accepted as valid atoms, but never implemented. Consequently, they simply returned the empty string, even for valid tags.
Signed-off-by: Jeff King <peff@peff.net> --- builtin-for-each-ref.c | 7 +++++++ t/t6300-for-each-ref.sh | 4 ++-- 2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/builtin-for-each-ref.c b/builtin-for-each-ref.c index 07d9c57..fef93d7 100644 --- a/builtin-for-each-ref.c +++ b/builtin-for-each-ref.c @@ -234,6 +234,13 @@ static void grab_tag_values(struct atom_value *val, int deref, struct object *ob name++; if (!strcmp(name, "tag")) v->s = tag->tag; + else if (!strcmp(name, "type") && tag->tagged) + v->s = typename(tag->tagged->type); + else if (!strcmp(name, "object") && tag->tagged) { + char *s = xmalloc(41); + strcpy(s, sha1_to_hex(tag->tagged->sha1)); + v->s = s; + } } } diff --git a/t/t6300-for-each-ref.sh b/t/t6300-for-each-ref.sh index 415e1d1..a3c8941 100755 --- a/t/t6300-for-each-ref.sh +++ b/t/t6300-for-each-ref.sh @@ -74,8 +74,8 @@ test_atom tag objectname 98b46b1d36e5b07909de1b3886224e3e81e87322 test_atom tag tree '' test_atom tag parent '' test_atom tag numparent '' -test_atom tag object '67a36f10722846e891fbada1ba48ed035de75581' failure -test_atom tag type 'commit' failure +test_atom tag object '67a36f10722846e891fbada1ba48ed035de75581' +test_atom tag type 'commit' test_atom tag author '' test_atom tag authorname '' test_atom tag authoremail ''
-- 1.5.6