Re: gitweb forgets to send utf8 header for raw blob views

From: Jakub Narebski <jnareb@gmail.com>
Date: May 31, 2008, 22:39 UTC
Message-ID: <200806010039.14663.jnareb@gmail.com>
In-Reply-To: <alpine.LNX.1.10.0805311703420.4055@fbirervta.pbzchgretzou.qr>

On Sat, 31 May 2008, Jan Engelhardt wrote:

Show 18 quoted lines

> On Friday 2008-05-30 10:18, Jakub Narebski wrote:
>>Jan Engelhardt <jengelh@medozas.de> writes:
>>
>>> I have configured gitweb to use utf8, and that works for text blob views 
>>> like on
>>> http://dev.medozas.de/gitweb.cgi?p=hxtools;a=blob;f=bin/git-forest;hb=HEAD
>>> but it does not for raw blob views like
>>> http://dev.medozas.de/gitweb.cgi?p=hxtools;a=blob_plain;f=bin/git-forest;hb=HEAD
>>
>> This can depend on configuration, both on gitweb configuration (you
>> can for example define $default_blob_plain_mimetype to 'text/plain;
>> charset=utf-8', and define $default_text_plain_charset to 'utf-8'),
>> and on your /etc/mime.types; gitweb does not add charset info if
>> mimetype is acquired from mime.types, which I guess is a mistake.
> 
> Thanks for the hint. Setting 
> 	our $default_text_plain_charset  = "utf-8";
> was all that was needed.

By the way, do you think that this should be the default for gitweb?

-- 
Jakub Narebski
Poland