git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] gitweb: Add charset info to "raw" blob output

From
Jakub Narebski <jnareb@gmail.com>
Date
May 31, 2008, 11:27 UTC
Message-ID
<20080531112513.30913.44393.stgit@localhost.localdomain>
In-Reply-To
<m3tzgg1a06.fsf@localhost.localdomain>

Always add charset info from $default_text_plain_charset (if it is defined) to "raw" (a=blob_plain) output for 'text/plain' blobs. Adding charset info in a special case was removed from blob_mimetype().

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
Please note that to have utf-8 for 'text/plain' blobs in blob_plain
view ("raw" output) you still have to set $default_text_plain_charset
to 'utf-8' (in gitweb configuration file).
 gitweb/gitweb.perl |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 57a1905..dd0f0ac 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2481,8 +2481,7 @@ sub blob_mimetype {
 	return $default_blob_plain_mimetype unless $fd;
 
 	if (-T $fd) {
-		return 'text/plain' .
-		       ($default_text_plain_charset ? '; charset='.$default_text_plain_charset : '');
+		return 'text/plain';
 	} elsif (! $filename) {
 		return 'application/octet-stream';
 	} elsif ($filename =~ m/\.png$/i) {
@@ -4397,6 +4396,9 @@ sub git_blob_plain {
 		or die_error(undef, "Couldn't cat $file_name, $hash");
 
 	$type ||= blob_mimetype($fd, $file_name);
+	if ($type eq 'text/plain' && defined $default_text_plain_charset) {
+		$type .= "; charset=$default_text_plain_charset";
+	}
 
 	# save as filename, even when no $file_name is given
 	my $save_as = "$hash";
Previous: Jakub NarebskiNext: Junio C Hamano
Message 4 of 12 in “gitweb forgets to send utf8 header for raw blob views”
  1. Jan EngelhardtMay 28, 2008
  2. Lea WiemannMay 29, 2008
  3. Jakub NarebskiMay 30, 2008
  4. gitweb: Add charset info to "raw" blob outputJakub Narebski, May 31, 2008
  5. Junio C HamanoMay 31, 2008
  6. Jakub NarebskiJun 1, 2008
  7. Jan EngelhardtJun 1, 2008
  8. Jan EngelhardtJun 1, 2008
  9. gitweb: Add charset info to "raw" output of 'text/plain' blobsJakub Narebski, Jun 3, 2008
  10. Jan EngelhardtMay 31, 2008
  11. Jakub NarebskiMay 31, 2008
  12. Jan EngelhardtJun 1, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.