git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/5] Move reset_index_file() to a new reset.c

From
Miklos Vajna <vmiklos@frugalware.org>
Date
May 24, 2008, 21:55 UTC
Message-ID
<20080524215530.GA27724@genesis.frugalware.org>
In-Reply-To
<alpine.LNX.1.00.0805240016230.19665@iabervon.org>
On Sat, May 24, 2008 at 12:21:42AM -0400, Daniel Barkalow <barkalow@iabervon.org> wrote:
Show 5 quoted lines
> You might as well use unpack_trees() directly here, instead of running a 
> separate command. In fact, you might skip making a function here, and just 
> call unpack_trees() where you'd use it. (And maybe have a function to 
> initialize a struct unpack_tree_options to some common defaults to make it 
> easy to see what's being done.)

Thanks for the suggestion, I did so; as a result now patch #1 and #3 are no longer necessary.

(I haven't sent out a new series yet, but it's in git://repo.or.cz/git/vmiklos.git builtin-merge.)

Maybe builtin-reset could use unpack_trees() directly as well? I don't know if it's just a question of "nobody did it yet", or there is some reason for not using unpack_trees() there.

Previous: Daniel Barkalow
Message 10 of 10 in “Build in merge”
  1. 0/5 Build in mergeMiklos Vajna, May 24, 2008
  2. 1/5 Move reset_index_file() to a new reset.cMiklos Vajna, May 24, 2008
  3. 2/5 Move split_cmdline() to libgitMiklos Vajna, May 24, 2008
  4. 3/5 Make verbosity configurable in reset_index_file()Miklos Vajna, May 24, 2008
  5. 4/5 Move commit_list_count() to commit.cMiklos Vajna, May 24, 2008
  6. 5/5 Build in mergeMiklos Vajna, May 24, 2008
  7. Kristian HøgsbergMay 27, 2008
  8. Miklos VajnaMay 27, 2008
  9. Daniel BarkalowMay 24, 2008
  10. Miklos VajnaMay 24, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.