Re: [PATCH 2/2] graph API: don't print branch lines for uninteresting merge parents

From: Teemu Likonen <tlikonen@iki.fi>
Date: May 24, 2008, 18:25 UTC
Message-ID: <20080524182530.GB2997@mithlond.arda.local>
In-Reply-To: <1211595851-11992-3-git-send-email-adam@adamsimpkins.net>

Adam Simpkins wrote (2008-05-23 19:24 -0700):

Show 15 quoted lines

> Previously, the graphing code printed lines coming out of a merge commit
> for all of its parents, even if some of them were uninteresting.  Now it
> only prints lines for interesting commits.
> 
> For example, for a merge commit where only the first parent is
> interesting, the code now prints:
> 
>   *  merge commit
>   *  interesting child
> 
> instead of:
> 
>   M  merge commit
>   |\
>   *  interesting child

I'd rather show merge commits always with M. They are still conceptually merges even if the current log view shows only one parent. This patch changes symbols * and M to be visual symbols, not logical symbols which I'd prefer.

For example user may be interested in finding certain merge but chooses to limit the output with a commit range. It helps if user can always trust the symbols * and M to have this conceptual difference.