[PATCH 1/2] graph API: fix graph mis-alignment after uninteresting commits

From: Adam Simpkins <adam@adamsimpkins.net>
Date: May 24, 2008, 02:24 UTC
Message-ID: <1211595851-11992-2-git-send-email-adam@adamsimpkins.net>
In-Reply-To: <1211595851-11992-1-git-send-email-adam@adamsimpkins.net>

The graphing code had a bug that caused it to output branch lines incorrectly after ignoring an uninteresting commit. When computing how to match up the branch lines from the current commit to the next one, it forgot to take into account that it needed to initially start with 2 empty spaces where the missing commit would have gone.

So, instead of drawing this,

| * | <- Commit with uninteresting parent
|  /
* |

It used to incorrectly draw this:

| * | <- Commit with uninteresting parent
* |

Signed-off-by: Adam Simpkins <adam@adamsimpkins.net>
---
 graph.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/graph.c b/graph.c
index 9d6ed30..400f014 100644
--- a/graph.c
+++ b/graph.c
@@ -190,7 +190,10 @@ static void graph_insert_into_new_columns(struct git_graph *graph,
 	 * Ignore uinteresting and pruned commits
 	 */
 	if (commit->object.flags & (UNINTERESTING | TREESAME))
+	{
+		*mapping_index += 2;
 		return;
+	}
 
 	/*
 	 * If the commit is already in the new_columns list, we don't need to

-- 
1.5.5.1.359.gebc23.dirty