Re: [PATCH] git-init: inform user of `git --bare init' option

From: Luciano Rocha <luciano@eurotux.com>
Date: May 23, 2008, 14:24 UTC
Message-ID: <20080523142432.GA8360@bit.office.eurotux.com>
In-Reply-To: <7vy761sgks.fsf@gitster.siamese.dyndns.org>

On Thu, May 22, 2008 at 11:02:59PM -0700, Junio C Hamano wrote:

Show 12 quoted lines

> Luciano Rocha <luciano@eurotux.com> writes:
> 
> > Creation of a bare repository isn't consistent:
> >
> > $ git init --bare
> > usage: git-init [-q | --quiet] [--template=<template-directory>] [--shared]
> > $ git --bare init
> > Initialized empty Git repository in ...
> 
> The examples do not demonstrate that "it isn't consistent".  It just
> demonstrates that it is easy for people to forget that --bare option is an
> option to the "git" potty itself and not an option to "git init".

Well, "git --help init" works the same as "git init --help", so "--bare" not working depending on its position isn't very consistent...

<patch snipped>

Show 5 quoted lines

> Given that you are adding a special case support for "git init --bare"
> anyway, a better approach to help people out of this easy confusion (and
> we have to admit that the confusion is very easy!) would be to make "git
> init --bare" pretend/behave as if the user said "git --bare init", don't
> you think?

Yes, but this was easy for me to do. The proper way, however, will take me more time.

-- 
Luciano Rocha <luciano@eurotux.com>
Eurotux Informática, S.A. <http://www.eurotux.com/>