git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: To page or not to page

From
Jeff King <peff@peff.net>
Date
May 16, 2008, 04:42 UTC
Message-ID
<20080516044238.GA6784@sigill.intra.peff.net>
In-Reply-To
<20080506055128.GA26311@sigill.intra.peff.net>
On Tue, May 06, 2008 at 01:51:28AM -0400, Jeff King wrote:
> So anyway, here is the less invasive version.
> [of configurable paging]

Gah. Lacking any more input, I was going to clean this up and re-submit, but it seems to fail some unrelated tests.

It appears that with this patch, you can no longer do:
  cd .git && git show HEAD

because of some awful ordering constraints in the wrapper. Specifically, looking in the config for pager.* entails calling git_path, which ends up calling setup_git_env, which says "I guess our git_dir is '.git'". Which is of course totally wrong, and calling setup_git_directory would find the right thing.

So the logic in setup_git_env seems bogus, but should basically never be invoked because we do generally call setup_git_directory_gently before then. Either it should probably call setup_git_directory_gently (though I am afraid of what awful side effects that could have), or it should just barf, and people should do setup_git_directory beforehand (and I'm sure that will break something too).

Blargh.
-Peff
Previous: Junio C HamanoNext: Jeff King
Message 26 of 31 in “To page or not to page”
  1. Kevin BallardMay 2, 2008
  2. Jeff KingMay 2, 2008
  3. Junio C HamanoMay 2, 2008
  4. Kevin BallardMay 2, 2008
  5. Junio C HamanoMay 2, 2008
  6. Bart TrojanowskiMay 2, 2008
  7. Pedro MeloMay 2, 2008
  8. Kevin BallardMay 2, 2008
  9. Wincent ColaiutaMay 2, 2008
  10. Jeff KingMay 2, 2008
  11. Pedro MeloMay 2, 2008
  12. Aidan Van DykMay 2, 2008
  13. Wincent ColaiutaMay 2, 2008
  14. Kevin BallardMay 2, 2008
  15. Wincent ColaiutaMay 2, 2008
  16. Jeff KingMay 2, 2008
  17. Johannes SchindelinMay 2, 2008
  18. Jeff KingMay 2, 2008
  19. Junio C HamanoMay 2, 2008
  20. Jeff KingMay 2, 2008
  21. Junio C HamanoMay 2, 2008
  22. Jeff KingMay 5, 2008
  23. Jeff KingMay 6, 2008
  24. Jeff KingMay 6, 2008
  25. Junio C HamanoMay 11, 2008
  26. Jeff KingMay 16, 2008
  27. Jeff KingMay 16, 2008
  28. Johannes SchindelinMay 16, 2008
  29. Jakub NarebskiMay 2, 2008
  30. Jeff KingMay 2, 2008
  31. Jeff KingMay 2, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.