git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: To page or not to page

From
Jeff King <peff@peff.net>
Date
May 2, 2008, 12:55 UTC
Message-ID
<20080502125553.GB2923@sigill.intra.peff.net>
In-Reply-To
<7vd4o5xm62.fsf@gitster.siamese.dyndns.org>
On Thu, May 01, 2008 at 11:19:49PM -0700, Junio C Hamano wrote:
> Heh, I like it.  I briefly thought that pager.cat-file may wreak havoc on
> scripts, but our pager machanism should be clever enough not to, and
> cat-file is a valid variable name in the configuration file format ;-).

Yes, I sort of assumed that the pager "auto" setting would take care of most things. I guess somebody could be crazy enough to set pager to "always" and pager.mailinfo to "true", but I'm not sure that's worth avoiding.

My bigger worry is that this affects only builtins. Which makes it sufficient for turning off the pager for anything that does USE_PAGER. But you can't turn _on_ the pager for arbitrary commands (e.g., pager.pull would be ignored). And some commands use pagers from sub-commands; e.g., git-stash calls git-diff to show a stash; so turning off the pager entails setting pager.diff, with no way to differentiate between stash and regular diff.

So it would be inconsistent and expose implementation details. But maybe that is OK for now, and we just say "well, everything will become a builtin eventually." ;)

-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 20 of 31 in “To page or not to page”
  1. Kevin BallardMay 2, 2008
  2. Jeff KingMay 2, 2008
  3. Junio C HamanoMay 2, 2008
  4. Kevin BallardMay 2, 2008
  5. Junio C HamanoMay 2, 2008
  6. Bart TrojanowskiMay 2, 2008
  7. Pedro MeloMay 2, 2008
  8. Kevin BallardMay 2, 2008
  9. Wincent ColaiutaMay 2, 2008
  10. Jeff KingMay 2, 2008
  11. Pedro MeloMay 2, 2008
  12. Aidan Van DykMay 2, 2008
  13. Wincent ColaiutaMay 2, 2008
  14. Kevin BallardMay 2, 2008
  15. Wincent ColaiutaMay 2, 2008
  16. Jeff KingMay 2, 2008
  17. Johannes SchindelinMay 2, 2008
  18. Jeff KingMay 2, 2008
  19. Junio C HamanoMay 2, 2008
  20. Jeff KingMay 2, 2008
  21. Junio C HamanoMay 2, 2008
  22. Jeff KingMay 5, 2008
  23. Jeff KingMay 6, 2008
  24. Jeff KingMay 6, 2008
  25. Junio C HamanoMay 11, 2008
  26. Jeff KingMay 16, 2008
  27. Jeff KingMay 16, 2008
  28. Johannes SchindelinMay 16, 2008
  29. Jakub NarebskiMay 2, 2008
  30. Jeff KingMay 2, 2008
  31. Jeff KingMay 2, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.