Re: git clone broken in next

From: Jeff King <peff@peff.net>
Date: May 15, 2008, 04:50 UTC
Message-ID: <20080515045026.GA26161@sigill.intra.peff.net>
In-Reply-To: <20080515044402.GA3517@sigill.intra.peff.net>

On Thu, May 15, 2008 at 12:44:02AM -0400, Jeff King wrote:

Show 23 quoted lines

> Hmm, builtin-clone does seem to be completely broken. It looks like
> unpack_trees is not doing its job for some reason, but I haven't looked
> further. But it surprised me that we aren't testing anything as simple
> as "clone works". The test below currently fails (though I am getting
> other test failures which are presumably related).
> 
> ---
> diff --git a/t/t5601-clone.sh b/t/t5601-clone.sh
> index dc9d63d..593d1a3 100755
> --- a/t/t5601-clone.sh
> +++ b/t/t5601-clone.sh
> @@ -23,4 +23,11 @@ test_expect_success 'clone with excess parameters' '
>  
>  '
>  
> +test_expect_success 'clone checks out files' '
> +
> +	git clone src dst &&
> +	test -f dst/file
> +
> +'
> +
>  test_done

Just to be sure, I bisected this test, and sure enough, the problem commit is 8434c2f1 (build in clone). Daniel?

-Peff